Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Examples] Improve with-sentry readme #15205

Merged
merged 3 commits into from
Jul 17, 2020
Merged

[Examples] Improve with-sentry readme #15205

merged 3 commits into from
Jul 17, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented Jul 15, 2020

The current readme has wrong instructions and it's not clear enough about how to get the app running, also added deploy to Vercel buttons.

@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 15, 2020
@ijjk
Copy link
Member

ijjk commented Jul 15, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
buildDuration 14.1s 13.7s -434ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.366 2.442 ⚠️ +0.08
/ avg req/sec 1056.42 1023.95 ⚠️ -32.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.558 1.619 ⚠️ +0.06
/error-in-render avg req/sec 1604.85 1544.15 ⚠️ -60.7
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..cead.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.17 kB 6.17 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
index.html gzip 954 B 954 B ✓
link.html gzip 962 B 962 B ✓
withRouter.html gzip 948 B 948 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
buildDuration 14.9s 14.7s -192ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..cead.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.17 kB 6.17 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
_error.js 882 kB 882 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 882 kB 882 kB ✓
link.js 924 kB 924 kB ✓
routerDirect.js 918 kB 918 kB ✓
withRouter.js 918 kB 918 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 0655a50

@ijjk
Copy link
Member

ijjk commented Jul 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
buildDuration 12.6s 12.6s -32ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.006 2.036 ⚠️ +0.03
/ avg req/sec 1245.97 1228.16 ⚠️ -17.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.276 1.239 -0.04
/error-in-render avg req/sec 1959.59 2018.12 +58.53
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
buildDuration 13.7s 13.6s -122ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
_error.js 882 kB 882 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: ce3dcc1

@ijjk
Copy link
Member

ijjk commented Jul 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
buildDuration 9.5s 9.5s -2ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.567 1.559 -0.01
/ avg req/sec 1595.81 1603.39 +7.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 0.911 0.932 ⚠️ +0.02
/error-in-render avg req/sec 2745.51 2682.41 ⚠️ -63.1
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
buildDuration 10.8s 10.2s -643ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js update/with-sentry-readme Change
_error.js 882 kB 882 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 2b7d62a

@kodiakhq kodiakhq bot merged commit 14eb907 into vercel:canary Jul 17, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfades @ijjk @Timer